New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit webpack configs and background image #685

Closed

mcbouslog wants to merge 4 commits into master from edit-background-image-path

Contributor

mcbouslog commented Dec 10, 2024 •

edited

Loading

Staging branch URL: https://pr-685.lab-preview.zooniverse.org/

Fixes #250 .

Describe your changes.

adds publicPath: '/' to webpack configs
changes landing.styl background image to static url, not ideal, should be dynamic, but per change ^ this is a temporary fix to keep background image loading

Review Checklist

Does it work in all major browsers: Firefox, Chrome, Edge, Safari?
Can you rm -rf node_modules/ && npm install and app works as expected?
Are the tests passing locally and on Travis?

lcjohnso and others added 4 commits

December 9, 2024 17:10


          add public path back, pt1

57fcc32


          add public path back, pt2

2eb958b


          Edit background image path

e3a41f9


          Change background image url

17efba1

mcbouslog closed this

mcbouslog deleted the edit-background-image-path branch

December 10, 2024 19:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet